4 files changed, 293 insertions, 80 deletions

diff --git a/decoder/apply_fsa_models.cc b/decoder/apply_fsa_models.cc
index 2c10762b..5493d29f 100755
--- a/decoder/apply_fsa_models.cc
+++ b/decoder/apply_fsa_models.cc
@@ -1,4 +1,4 @@
-#include "maybe_update_bound.h"
+#include <queue>
 #include "apply_fsa_models.h"
 #include "hg.h"
 #include "ff_fsa_dynamic.h"
@@ -15,9 +15,24 @@
 #include "value_array.h"
 #include "d_ary_heap.h"
 #include "agenda.h"
+#include "show.h"
+#include <stdint.h>
 
 #define DFSA(x) x
+//fsa earley chart
+
 #define DPFSA(x) x
+//prefix trie
+
+#define PRINT_PREFIX 1
+#if PRINT_PREFIX
+# define IF_PRINT_PREFIX(x) x
+#else
+# define IF_PRINT_PREFIX(x)
+#endif
+// keep backpointers in prefix trie so you can print a meaningful node id
+
+static const unsigned FSA_AGENDA_RESERVE=10; // TODO: increase to 1<<24 (16M)
 
 using namespace std;
 
@@ -51,10 +66,9 @@ vs.
 3) * -> x . *
 
 with 3, we predict all sorts of useless items - that won't give us our goal A and may not partcipate in any parse.  this is not a good option at all.
-*/
 
-#define TRIE_START_LHS 1
-// 1 is option 1) above.  0 would be option 3), which is dumb
+I'm using option 1.
+*/
 
 // if we don't greedy-binarize, we want to encode recognized prefixes p (X -> p . rest) efficiently.  if we're doing this, we may as well also push costs so we can best-first select rules in a lazy fashion.  this is effectively left-branching binarization, of course.
 template <class K,class V,class Hash>
@@ -73,14 +87,33 @@ struct get_second {
 };
 
 struct PrefixTrieNode;
+typedef PrefixTrieNode *NodeP;
+typedef PrefixTrieNode const *NodePc;
+
+// for debugging prints only
+struct TrieBackP {
+  WordID w;
+  NodePc from;
+  TrieBackP(WordID w=0,NodePc from=0) : w(w),from(from) {  }
+};
+
+FsaFeatureFunction const* print_fsa=0;
+CFG const* print_cfg=0;
+inline void print_cfg_rhs(std::ostream &o,WordID w) {
+  if (print_cfg)
+    print_cfg->print_rhs_name(o,w);
+  else
+    CFG::static_print_rhs_name(o,w);
+}
+
 struct PrefixTrieEdge {
 //  PrefixTrieEdge() {  }
-//  explicit PrefixTrieEdge(prob_t p) : p(p),dest(0) {  }
-  prob_t p;// viterbi additional prob, i.e. product over path incl. p_final = total rule prob
+//  explicit PrefixTrieEdge(best_t p) : p(p),dest(0) {  }
+  best_t p;// viterbi additional prob, i.e. product over path incl. p_final = total rule prob
   //DPFSA()
   // we can probably just store deltas, but for debugging remember the full p
-  //    prob_t delta; //
-  PrefixTrieNode *dest;
+  //    best_t delta; //
+  NodeP dest;
   bool is_final() const { return dest==0; }
   WordID w; // for lhs, this will be nonneg NTHandle instead.  //  not set if is_final() // actually, set to lhs nt index
 
@@ -88,23 +121,61 @@ struct PrefixTrieEdge {
   inline bool operator <(PrefixTrieEdge const& o) const {
     return o.p<p;
   }
+  PRINT_SELF(PrefixTrieEdge)
+  void print(std::ostream &o) const {
+    print_cfg_rhs(o,w);
+    o<<"{"<<p<<"}->"<<dest;
+  }
+
 };
 
+
+//note: ending a rule is handled with a special final edge, so that possibility can be explored in best-first order along with the rest (alternative: always finish a final rule by putting it on queue).  this edge has no symbol on it.
 struct PrefixTrieNode {
-  prob_t p; // viterbi (max prob) of rule this node leads to - when building.  telescope later onto edges for best-first.
-#if TRIE_START_LHS
-//  bool final; // may also have successors, of course.  we don't really need to track this; a null dest edge in the adj list lets us encounter the fact in best first order.
-//  prob_t p_final; // additional prob beyond what we already paid. while building, this is the total prob
+  best_t p; // viterbi (max prob) of rule this node leads to - when building.  telescope later onto edges for best-first.
+  bool final; // may also have successors, of course.  we don't really need to track this; a null dest edge in the adj list lets us encounter the fact in best first order.
+  typedef TrieBackP BP;
+  typedef std::vector<BP> BPs;
+  void back_vec(BPs &ns) const {
+    IF_PRINT_PREFIX(if(backp.from) { ns.push_back(backp); backp.from->back_vec(ns); })
+  }
+
+  BPs back_vec() const {
+    BPs ret;
+    back_vec(ret);
+    return ret;
+  }
+
+  void print_back_str(std::ostream &o) const {
+    BPs back=back_vec();
+    unsigned i=back.size();
+    if (!i) {
+      o<<"PrefixTrieNode@"<<(uintptr_t)this;
+      return;
+    }
+    bool first=true;
+    while (i--<=0) {
+      if (!first) o<<',';
+      first=false;
+      WordID w=back[i].w;
+      print_cfg_rhs(o,w);
+    }
+  }
+  std::string back_str() const {
+    std::ostringstream o;
+    print_back_str(o);
+    return o.str();
+  }
+
+//  best_t p_final; // additional prob beyond what we already paid. while building, this is the total prob
 // instead of storing final, we'll say that an edge with a NULL dest is a final edge.  this way it gets sorted into the list of adj.
 
   // instead of completed map, we have trie start w/ lhs.
   NTHandle lhs; // nonneg. - instead of storing this in Item.
-#else
-  typedef FSA_MAP(LHS,RuleHandle) Completed; // can only have one rule w/ a given signature (duplicates should be collapsed when making CFG).  but there may be multiple rules, with different LHS
-  Completed completed;
-#endif
+  IF_PRINT_PREFIX(BP backp;)
+
   enum { ROOT=-1 };
-  explicit PrefixTrieNode(NTHandle lhs=ROOT,prob_t p=1) : p(p),lhs(lhs) {
+  explicit PrefixTrieNode(NTHandle lhs=ROOT,best_t p=1) : p(p),lhs(lhs),IF_PRINT_PREFIX(backp()) {
     //final=false;
   }
   bool is_root() const { return lhs==ROOT; } // means adj are the nonneg lhs indices, and we have the index edge_for still available
@@ -134,12 +205,13 @@ public:
     }
   }
   template <class PV>
-  void index_root(PV &v) {
-    v.resize(adj.size());
+  void index_lhs(PV &v) {
     for (int i=0,e=adj.size();i!=e;++i) {
       PrefixTrieEdge const& e=adj[i];
       // assert(e.p.is_1());  // actually, after done_building, e will have telescoped dest->p/p.
-      v[e.w]=e.dest;
+      NTHandle n=e.w;
+      assert(n>=0);
+      v[n]=e.dest;
     }
   }
 
@@ -172,43 +244,47 @@ public:
   typedef WordID W;
 
   // let's compute p_min so that every rule reachable from the created node has p at least this low.
-  PrefixTrieNode *improve_edge(PrefixTrieEdge const& e,prob_t rulep) {
-    PrefixTrieNode *d=e.dest;
-    maybe_increase_max(d->p,rulep);
+  NodeP improve_edge(PrefixTrieEdge const& e,best_t rulep) {
+    NodeP d=e.dest;
+    maybe_improve(d->p,rulep);
     return d;
   }
 
-  inline PrefixTrieNode *build(W w,prob_t rulep) {
+  inline NodeP build(W w,best_t rulep) {
     return build(lhs,w,rulep);
   }
-  inline PrefixTrieNode *build_lhs(NTHandle w,prob_t rulep) {
+  inline NodeP build_lhs(NTHandle w,best_t rulep) {
     return build(w,w,rulep);
   }
 
-  PrefixTrieNode *build(NTHandle lhs_,W w,prob_t rulep) {
+  NodeP build(NTHandle lhs_,W w,best_t rulep) {
     PrefixTrieEdgeFor::iterator i=edge_for.find(w);
     if (i!=edge_for.end())
       return improve_edge(i->second,rulep);
     PrefixTrieEdge &e=edge_for[w];
-    return e.dest=new PrefixTrieNode(lhs_,rulep);
+    NodeP r=new PrefixTrieNode(lhs_,rulep);
+    IF_PRINT_PREFIX(r->backp=BP(w,this));
+    return e.dest=r;
   }
 
-  void set_final(NTHandle lhs_,prob_t pf) {
+  void set_final(NTHandle lhs_,best_t pf) {
     assert(no_adj());
-//    final=true; // don't really need to track this.
+    final=true;
+    /*
     PrefixTrieEdge &e=edge_for[-1];
     e.p=pf;
     e.dest=0;
     e.w=lhs_;
     if (pf>p)
       p=pf;
+    */
   }
 
 private:
   void destroy_children() {
     assert(adj.size()>=edge_for.size());
     for (int i=0,e=adj.size();i<e;++i) {
-      PrefixTrieNode *c=adj[i].dest;
+      NodeP c=adj[i].dest;
       if (c) { // final state has no end
         delete c;
       }
@@ -220,31 +296,33 @@ public:
   }
 };
 
-#if TRIE_START_LHS
-//Trie starts with lhs (nonneg index), then continues w/ rhs (mixed >0 word, else NT)
-#else
-// just rhs.  i think item names should exclude lhs if possible (most sharing).  get prefix cost w/ forward = viterbi (global best-first admissable h only) and it should be ok?
-#endif
 
+//Trie starts with lhs (nonneg index), then continues w/ rhs (mixed >0 word, else NT)
+// trie ends with final edge, which points to a per-lhs prefix node
 struct PrefixTrie {
   CFG *cfgp;
   Rules const* rulesp;
   Rules const& rules() const { return *rulesp; }
   CFG const& cfg() const { return *cfgp; }
   PrefixTrieNode root;
-
-  PrefixTrie(CFG &cfg) : cfgp(&cfg),rulesp(&cfg.rules) {
+  typedef std::vector<NodeP> LhsToTrie; // will have to check lhs2[lhs].p for best cost of some rule with that lhs, then use edge deltas after?  they're just caching a very cheap computation, really
+  LhsToTrie lhs2; // no reason to use a map or hash table; every NT in the CFG will have some rule rhses.  lhs_to_trie[i]=root.edge_for[i], i.e. we still have a root trie node conceptually, we just access through this since it's faster.
+  typedef LhsToTrie LhsToComplete;
+  LhsToComplete lhs2complete; // the sentinel "we're completing" node (dot at end) for that lhs.  special case of suffix-set=same trie minimization (aka right branching binarization) // these will be used to track kbest completions, along with a l state (r state will be in the list)
+  PrefixTrie(CFG &cfg) : cfgp(&cfg),rulesp(&cfg.rules),lhs2(cfg.nts.size(),0),lhs2complete(cfg.nts.size()) {
 //    cfg.SortLocalBestFirst(); // instead we'll sort in done_building_r
+    print_cfg=cfgp;
     cfg.VisitRuleIds(*this);
     root.done_building_r();
     root.index_adj(); // maybe the index we use for building trie should be replaced by a much larger/faster table since we look up by lhs many times in parsing?
-//TODO:
+    root.index_lhs(lhs2);
   }
+
   void operator()(int ri) const {
     Rule const& r=rules()[ri];
     NTHandle lhs=r.lhs;
-    prob_t p=r.p;
-    PrefixTrieNode *n=const_cast<PrefixTrieNode&>(root).build_lhs(lhs,p);
+    best_t p=r.p;
+    NodeP n=const_cast<PrefixTrieNode&>(root).build_lhs(lhs,p);
     for (RHS::const_iterator i=r.rhs.begin(),e=r.rhs.end();;++i) {
       if (i==e) {
         n->set_final(lhs,p);
@@ -254,60 +332,167 @@ struct PrefixTrie {
     }
 //    root.build(lhs,r.p)->build(r.rhs,r.p);
   }
+  inline NodeP lhs2_ex(NTHandle n) const {
+    NodeP r=lhs2[n];
+    if (!r) throw std::runtime_error("PrefixTrie: no CFG rule w/ lhs "+cfgp->nt_name(n));
+    return r;
+  }
+};
+
+
+// these should go in a global best-first queue
+struct ItemPrio {
+  // NOTE: sum = viterbi (max)
+  ItemPrio() : priority(init_0()),inner(init_0()) {  }
+  best_t priority; // includes inner prob. (forward)
+  /* The forward probability alpha_i(X[k]->x.y) is the sum of the probabilities of all
+     constrained paths of length i that end in state X[k]->x.y*/
+  best_t inner;
+  /* The inner probability beta_i(X[k]->x.y) is the sum of the probabilities of all
+     paths of length i-k that start in state X[k,k]->.xy and end in X[k,i]->x.y, and generate the input symbols x[k,...,i-1] */
+  template<class O>
+  void print(O &o) const {
+    o<<priority; // TODO: show/use inner?
+  }
+  typedef ItemPrio self_type;
+  SELF_TYPE_PRINT
 
 };
 
 typedef std::size_t ItemHash;
 
-struct Item {
-  explicit Item(PrefixTrieNode *dot,int next=0) : dot(dot),next(next) {  }
-  PrefixTrieNode *dot; // dot is a function of the stuff already recognized, and gives a set of suffixes y to complete to finish a rhs for lhs() -> dot y.  for a lhs A -> . *, this will point to lh2[A]
-  int next; // index of dot->adj to complete (if dest==0), or predict (if NT), or scan (if word)
-  NTHandle lhs() const { return dot->lhs; }
+
+struct ItemKey {
+  explicit ItemKey(NodeP start,Bytes const& start_state) : dot(start),q(start_state),r(start_state) {  }
+  explicit ItemKey(NodeP dot) : dot(dot) {  }
+  NodeP dot; // dot is a function of the stuff already recognized, and gives a set of suffixes y to complete to finish a rhs for lhs() -> dot y.  for a lhs A -> . *, this will point to lh2[A]
+  Bytes q,r; // (q->r are the fsa states; if r is empty it means
+  bool operator==(ItemKey const& o) const {
+    return dot==o.dot && q==o.q && r==o.r;
+  }
   inline ItemHash hash() const {
-    return GOLDEN_MEAN_FRACTION*next^((ItemHash)dot>>4); // / sizeof(PrefixTrieNode), approx., i.e. lower order bits of ptr are nonrandom
+    ItemHash h=GOLDEN_MEAN_FRACTION*(ItemHash)(dot-NULL); // i.e. lower order bits of ptr are nonrandom
+    using namespace boost;
+    hash_combine(h,q);
+    hash_combine(h,r);
+    return h;
+  }
+  template<class O>
+  void print(O &o) const {
+    o<<"lhs="<<lhs();
+    if (dot)
+      dot->print_back_str(o);
+    if (print_fsa) {
+      o<<'/';
+      print_fsa->print_state(o,&q[0]);
+      o<<"->";
+      print_fsa->print_state(o,&r[0]);
+    }
   }
+  NTHandle lhs() const { return dot->lhs; }
+  typedef ItemKey self_type;
+  SELF_TYPE_PRINT
 };
-
-inline ItemHash hash_value(Item const& x) {
+inline ItemHash hash_value(ItemKey const& x) {
   return x.hash();
 }
+ItemKey null_item((PrefixTrieNode*)0);
+
+struct Item;
+typedef Item *ItemP;
+
+/* we use a single type of item so it can live in a single best-first queue.  we hold them by pointer so they can have mutable state, e.g. priority/location, but also lists of predictions and kbest completions (i.e. completions[L,r] = L -> * (r,s), by 1best for each possible s.  we may discover more s later.  we could use different subtypes since we hold by pointer, but for now everything will be packed as variants of Item */
+struct Item : ItemPrio,ItemKey {
+  explicit Item(NodeP dot,int next=0) : ItemKey(dot),next(next),from(0) {  }
+  explicit Item(NodeP dot,FFState const& state,int next=0) : ItemKey(dot,state),next(next),from(0) {  }
+  unsigned location;
+  typedef std::queue<ItemP> Predicted;
+  Predicted predicted; // this is empty, unless this is a predicted L -> .asdf item, or a to-complete L -> asdf .
+  int next; // index of dot->adj to complete (if dest==0), or predict (if NT), or scan (if word).  note: we could store pointer inside adj since it and trie are @ fixed addrs.  less pointer arith, more space.
+  ItemP from; //backpointer - 0 for L -> . asdf for the rest; L -> a .sdf, it's the L -> .asdf item.
+  ItemP predicted_from() const {
+    ItemP p=(ItemP)this;
+    while(p->from) p=p->from;
+    return p;
+  }
+  template<class O>
+  void print(O &o) const {
+    o<< '[';
+    ItemKey::print(o);
+    o<<' ';
+    ItemPrio::print(o);
+    o<<" next="<<next;
+    o<< ']';
+  }
+  typedef Item self_type;
+  SELF_TYPE_PRINT
+};
 
-Item null_item((PrefixTrieNode*)0);
-
-// these should go in a global best-first queue
-struct ItemP {
-  ItemP() : forward(init_0()),inner(init_0()) {  }
-  prob_t forward; // includes inner prob.
-  // NOTE: sum = viterbi (max)
-  /* The forward probability alpha_i(X[k]->x.y) is the sum of the probabilities of all
-     constrained paths of length that end in state X[k]->x.y*/
-  prob_t inner;
-  /* The inner probability beta_i(X[k]->x.y) is the sum of the probabilities of all
-     paths of length i-k that start in state X[k,k]->.xy and end in X[k,i]->x.y, and generate the input symbols x[k,...,i-1] */
+struct GetItemKey {
+  typedef Item argument_type;
+  typedef ItemKey result_type;
+  result_type const& operator()(Item const& i) const { return i; }
+  template <class T>
+  T const& operator()(T const& t) const { return t; }
 };
 
+/* here's what i imagine (best first):
+   all of these are looked up in a chart which includes the fsa states as part of the identity
+
+   perhaps some items are ephemeral and never reused (e.g. edge items of a cube, where we delay traversing trie based on probabilities), but in all ohter cases we make entirely new objects derived from the original one (memoizing).  let's ignore lazier edge items for now and always push all successors onto heap.
+
+   initial item (predicted): GOAL_NT -> . * (trie root for that lhs), start, start (fsa start states).  has a list of
+
+   completing item ( L -> * . needs to queue all the completions immediately.  when predicting before a completion happens, add to prediction list.  after it happens, immediately use the completed bests.  this is confusing to me: the completions for an original NT w/ a given r state may end up in several different ones.  we don't only care about the 1 best cost r item but all the different r.
+
+   the prediction's left/right uses the predictor's right
+
+ */
+template <class FsaFF=FsaFeatureFunction>
 struct Chart {
-  //Agenda<Item> a;
   //typedef HASH_MAP<Item,ItemP,boost::hash<Item> > Items;
   //typedef Items::iterator FindItem;
   //typedef std::pair<FindItem,bool> InsertItem;
 //  Items items;
   CFG &cfg; // TODO: remove this from Chart
+  SentenceMetadata const& smeta;
+  FsaFF const& fsa;
   NTHandle goal_nt;
   PrefixTrie trie;
-  typedef std::vector<PrefixTrieNode *> LhsToTrie; // will have to check lhs2[lhs].p for best cost of some rule with that lhs, then use edge deltas after?  they're just caching a very cheap computation, really
-  LhsToTrie lhs2; // no reason to use a map or hash table; every NT in the CFG will have some rule rhses.  lhs_to_trie[i]=root.edge_for[i], i.e. we still have a root trie node conceptually, we just access through this since it's faster.
+  typedef Agenda<Item,BetterP,GetItemKey> A;
+  A a;
+  void best_first(unsigned kbest=1) {
+    BetterP better;
+    assert(kbest==1); //TODO: k-best via best-first requires revisiting best things again and adjusting desc.  tricky.
+    while(!a.empty()) {
+      ItemP top=a.pop();
+      best_t b=a.best(); // remember; best_t a<b means a better than (higher prob) than b
+      best_t topb=top->priority;
+      best_t trie_stop_p=topb/b;
+      NodeP d=top->dot;
+      PrefixTrieNode::Adj const& adj=d->adj;
+      int n=top->next;
+      for (int m=adj.size();n<m;++n) { // cube corner
+        PrefixTrieEdge const& te=adj[m];
+        if (better(te.p,trie_stop_p)) {
+          SHOWM2(DFSA,"trying adj ",m,te)
+        } else {
+          break;
+        }
 
-  void enqueue(Item const& item,ItemP const& p) {
-//    FindItem f=items.find(item);
-//    if (f==items.end()) ;
+      }
+
+
+    }
 
   }
 
-  Chart(CFG &cfg) :cfg(cfg),trie(cfg) {
+  Chart(CFG &cfg,SentenceMetadata const& smeta,FsaFF const& fsa,unsigned reserve=FSA_AGENDA_RESERVE)
+    : cfg(cfg),smeta(smeta),fsa(fsa),trie(cfg),a(reserve) {
+    assert(fsa.state_bytes());
+    print_fsa=&fsa;
     goal_nt=cfg.goal_nt;
-    trie.root.index_root(lhs2);
+    a.add(a.construct(trie.lhs2_ex(goal_nt),fsa.start));
   }
 };
 
@@ -317,6 +502,7 @@ struct Chart {
 
 DEFINE_NAMED_ENUM(FSA_BY)
 
+template <class FsaFF=FsaFeatureFunction>
 struct ApplyFsa {
   ApplyFsa(HgCFG &i,
            const SentenceMetadata& smeta,
@@ -327,9 +513,10 @@ struct ApplyFsa {
     )
     :hgcfg(i),smeta(smeta),fsa(fsa),weights(weights),by(by),oh(oh)
   {
+    stateless=!fsa.state_bytes();
   }
   void Compute() {
-    if (by.IsBottomUp())
+    if (by.IsBottomUp() || stateless)
       ApplyBottomUp();
     else
       ApplyEarley();
@@ -340,30 +527,33 @@ struct ApplyFsa {
 private:
   CFG cfg;
   HgCFG &hgcfg;
-  const SentenceMetadata& smeta;
-  const FsaFeatureFunction& fsa;
+  SentenceMetadata const& smeta;
+  FsaFF const& fsa;
 //  WeightVector weight_vector;
   DenseWeightVector weights;
   ApplyFsaBy by;
   Hypergraph* oh;
   std::string cfg_out;
+  bool stateless;
 };
 
-void ApplyFsa::ApplyBottomUp()
+template <class F>
+void ApplyFsa<F>::ApplyBottomUp()
 {
   assert(by.IsBottomUp());
   FeatureFunctionFromFsa<FsaFeatureFunctionFwd> buff(&fsa);
   buff.Init(); // mandatory to call this (normally factory would do it)
   vector<const FeatureFunction*> ffs(1,&buff);
   ModelSet models(weights, ffs);
-  IntersectionConfiguration i(by.BottomUpAlgorithm(),by.pop_limit);
+  IntersectionConfiguration i(stateless ? BU_FULL : by.BottomUpAlgorithm(),by.pop_limit);
   ApplyModelSet(hgcfg.ih,smeta,models,i,oh);
 }
 
-void ApplyFsa::ApplyEarley()
+template <class F>
+void ApplyFsa<F>::ApplyEarley()
 {
   hgcfg.GiveCFG(cfg);
-  Chart chart(cfg);
+  Chart<F> chart(cfg,smeta,fsa);
   // don't need to uniq - option to do that already exists in cfg_options
   //TODO:
 }
@@ -376,7 +566,7 @@ void ApplyFsaModels(HgCFG &i,
                     ApplyFsaBy const& by,
                     Hypergraph* oh)
 {
-  ApplyFsa a(i,smeta,fsa,weight_vector,by,oh);
+  ApplyFsa<FsaFeatureFunction> a(i,smeta,fsa,weight_vector,by,oh);
   a.Compute();
 }
 
diff --git a/decoder/cfg.h b/decoder/cfg.h
index 9be0926d..79ae6f33 100755
--- a/decoder/cfg.h
+++ b/decoder/cfg.h
@@ -62,6 +62,28 @@ struct CFG {
   void print_nt_name(std::ostream &o,NTHandle n) const {
     o << nts[n].from << n;
   }
+  std::string nt_name(NTHandle n) const {
+    std::ostringstream o;
+    print_nt_name(o,n);
+    return o.str();
+  }
+  void print_rhs_name(std::ostream &o,WordID w) const {
+    if (w<=0) print_nt_name(o,-w);
+    else o<<TD::Convert(w);
+  }
+  std::string rhs_name(WordID w) const {
+    if (w<=0) return nt_name(-w);
+    else return TD::Convert(w);
+  }
+  static void static_print_rhs_name(std::ostream &o,WordID w) {
+    if (w<=0) o<<'['<<-w<<']';
+    else o<<TD::Convert(w);
+  }
+  static std::string static_rhs_name(WordID w) {
+    std::ostringstream o;
+    static_print_rhs_name(o,w);
+    return o.str();
+  }
 
   typedef std::pair<WordID,WordID> BinRhs;
 
diff --git a/decoder/ff.h b/decoder/ff.h
index 80a880d8..904b9eb8 100644
--- a/decoder/ff.h
+++ b/decoder/ff.h
@@ -9,6 +9,7 @@
 # define DBGINIT(a)
 #endif
 
+#include <stdint.h>
 #include <vector>
 #include <cstring>
 #include "fdict.h"
@@ -243,7 +244,7 @@ void show_all_features(std::vector<FFp> const& models_,DenseWeightVector &weight
   return show_features(all_features(models_,weights_,&warn,warn_fid_0),weights_,out,warn,warn_zero_wt);
 }
 
-typedef ValueArray<char> FFState; // this is about 10% faster than string.
+typedef ValueArray<uint8_t> FFState; // this is about 10% faster than string.
 //typedef std::string FFState;
 
 //FIXME: only context.data() is required to be contiguous, and it becomes invalid after next string operation.  use ValueArray instead? (higher performance perhaps, save a word due to fixed size)
diff --git a/decoder/ff_fsa_data.h b/decoder/ff_fsa_data.h
index e60bce45..d215e940 100755
--- a/decoder/ff_fsa_data.h
+++ b/decoder/ff_fsa_data.h
@@ -36,7 +36,7 @@ struct FsaFeatureFunctionData
     return o;
   }
 
-  FsaFeatureFunctionData(int statesz=0,Sentence const& end_sentence_phrase=Sentence()) : ssz(statesz),start(statesz),h_start(statesz),end_phrase_(end_sentence_phrase) {
+  FsaFeatureFunctionData(int statesz=0,Sentence const& end_sentence_phrase=Sentence()) : start(statesz),h_start(statesz),end_phrase_(end_sentence_phrase),ssz(statesz) {
     debug_=true;
     sync_to_=0;
   }
@@ -86,10 +86,10 @@ struct FsaFeatureFunctionData
   }
 
   Features features_;
-protected:
-  int ssz; // don't forget to set this. default 0 (it may depend on params of course)
   Bytes start,h_start; // start state and estimated-features (heuristic) start state.  set these.  default empty.
   Sentence end_phrase_; // words appended for final traversal (final state cost is assessed using Scan) e.g. "</s>" for lm.
+protected:
+  int ssz; // don't forget to set this. default 0 (it may depend on params of course)
   // this can be called instead or after constructor (also set bytes and end_phrase_)
   void set_state_bytes(int sb=0) {
     if (start.size()!=sb) start.resize(sb);