diff options
| author | Chris Dyer <cdyer@cs.cmu.edu> | 2011-05-03 01:02:45 -0400 |
|---|---|---|
| committer | Chris Dyer <cdyer@cs.cmu.edu> | 2011-05-03 01:02:45 -0400 |
| commit | 520e03c12ffb6da89a66ecf9b9e46eeb3a3c8087 (patch) | |
| tree | d34ff0393cca43fa66a0606c2f4ffcf78903a5a6 /decoder | |
| parent | 9449e0e1ade2e706dfc6e7a71eceadb0d5ed700b (diff) | |
weight setting bug
Diffstat (limited to 'decoder')
| -rw-r--r-- | decoder/decoder.cc | 5 | ||||
| -rw-r--r-- | decoder/ff.h | 3 |
2 files changed, 7 insertions, 1 deletions
diff --git a/decoder/decoder.cc b/decoder/decoder.cc index 0d7e84ad..d8dd0c61 100644 --- a/decoder/decoder.cc +++ b/decoder/decoder.cc @@ -176,8 +176,11 @@ struct DecoderImpl { bool Decode(const string& input, DecoderObserver*); void SetWeights(const vector<double>& weights) { init_weights = weights; - for (int i = 0; i < rescoring_passes.size(); ++i) + for (int i = 0; i < rescoring_passes.size(); ++i) { + if (rescoring_passes[i].models) + rescoring_passes[i].models->SetWeights(weights); rescoring_passes[i].weight_vector = weights; + } } void SetId(int next_sent_id) { sent_id = next_sent_id - 1; } diff --git a/decoder/ff.h b/decoder/ff.h index 89b8b067..c3aa9b6d 100644 --- a/decoder/ff.h +++ b/decoder/ff.h @@ -264,6 +264,9 @@ class ModelSet { ModelSet(const std::vector<double>& weights, const std::vector<const FeatureFunction*>& models); + // TODO stop stupid copy + void SetWeights(const std::vector<double>& w) { weights_ = w; } + // sets edge->feature_values_ and edge->edge_prob_ // NOTE: edge must not necessarily be in hg.edges_ but its TAIL nodes // must be. edge features are supposed to be overwritten, not added to (possibly because rule features aren't in ModelSet so need to be left alone |