summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--decoder/hg.h2
-rwxr-xr-xgraehl/NOTES.earley4
-rwxr-xr-xutils/show.h5
3 files changed, 7 insertions, 4 deletions
diff --git a/decoder/hg.h b/decoder/hg.h
index 074213ac..76b2b8f0 100644
--- a/decoder/hg.h
+++ b/decoder/hg.h
@@ -72,7 +72,7 @@ public:
// TODO get rid of edge_prob_? (can be computed on the fly as the dot
// product of the weight vector and the feature values)
struct Edge {
-// int poplimit; //TODO: cube pruning per edge limit? per node didn't work well at all.
+// int poplimit; //TODO: cube pruning per edge limit? per node didn't work well at all. also, inside cost + outside(node) is the same information i'd use to set a per-edge limit anyway - and nonmonotonicity in cube pruning may mean it's good to favor edge (in same node) w/ relatively worse score
Edge() : i_(-1), j_(-1), prev_i_(-1), prev_j_(-1) {}
Edge(int id,Edge const& copy_pod_from) : id_(id) { copy_pod(copy_pod_from); } // call copy_features yourself later.
Edge(int id,Edge const& copy_from,TailNodeVector const& tail) // fully inits - probably more expensive when push_back(Edge(...)) than setting after
diff --git a/graehl/NOTES.earley b/graehl/NOTES.earley
index 9b8bf1fc..6f94f898 100755
--- a/graehl/NOTES.earley
+++ b/graehl/NOTES.earley
@@ -84,3 +84,7 @@ then X[k,i]->rY.s (a',b') with a' += a*b'', b' += b*b''
(this is summing over all derivations)
+
+==========
+
+is forward cost viterbi fine? i.e. can i have items whose names ignore the lhs NT (look up predictions that i finish lazily / graph structured?)
diff --git a/utils/show.h b/utils/show.h
index a687868c..6f601d47 100755
--- a/utils/show.h
+++ b/utils/show.h
@@ -3,7 +3,9 @@
#ifndef SHOWS
#include <iostream>
+#define SHOWS std::cerr
#endif
+
/* usage:
#if DEBUG
# define IFD(x) x
@@ -23,9 +25,6 @@ careful: none of this is wrapped in a block. so you can't use one of these macr
*/
-#ifndef SHOWS
-#define SHOWS std::cerr
-#endif
#define SHOWP(IF,x) IF(SHOWS<<x;)
#define SHOWNL(IF) SHOWP("\n")