summaryrefslogtreecommitdiff
path: root/extractor/data_array.h
diff options
context:
space:
mode:
authorPaul Baltescu <pauldb89@gmail.com>2013-02-22 11:02:10 +0000
committerPaul Baltescu <pauldb89@gmail.com>2013-02-22 11:02:10 +0000
commit4679f78193a826201055ce7bb2e01b5ad64bf04b (patch)
tree720abd12dfad2da364cf72f825dcf2415f0110d6 /extractor/data_array.h
parent5f08d976c857c1353ac623f0adbbe5597800d644 (diff)
Updated unit tests for data array.
Diffstat (limited to 'extractor/data_array.h')
-rw-r--r--extractor/data_array.h6
1 files changed, 3 insertions, 3 deletions
diff --git a/extractor/data_array.h b/extractor/data_array.h
index 7c120b3c..96950789 100644
--- a/extractor/data_array.h
+++ b/extractor/data_array.h
@@ -15,6 +15,9 @@ enum Side {
TARGET
};
+// TODO: This class has features for both the source and target data arrays.
+// Maybe we can save some memory by having more specific implementations (e.g.
+// sentence_id is only needed for the source data array).
class DataArray {
public:
static int NULL_WORD;
@@ -48,7 +51,6 @@ class DataArray {
virtual int GetSentenceStart(int position) const;
- //TODO(pauldb): Add unit tests.
virtual int GetSentenceLength(int sentence_id) const;
virtual int GetSentenceId(int position) const;
@@ -67,8 +69,6 @@ class DataArray {
unordered_map<string, int> word2id;
vector<string> id2word;
vector<int> data;
- // TODO(pauldb): We only need sentence_id for the source language. Maybe we
- // can save some memory here.
vector<int> sentence_id;
vector<int> sentence_start;
};