From f96dcb3cf3555db815137289bfca45c9adfcb744 Mon Sep 17 00:00:00 2001 From: Paul Baltescu Date: Fri, 22 Feb 2013 11:02:10 +0000 Subject: Updated unit tests for data array. --- extractor/data_array.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'extractor/data_array.h') diff --git a/extractor/data_array.h b/extractor/data_array.h index 7c120b3c..96950789 100644 --- a/extractor/data_array.h +++ b/extractor/data_array.h @@ -15,6 +15,9 @@ enum Side { TARGET }; +// TODO: This class has features for both the source and target data arrays. +// Maybe we can save some memory by having more specific implementations (e.g. +// sentence_id is only needed for the source data array). class DataArray { public: static int NULL_WORD; @@ -48,7 +51,6 @@ class DataArray { virtual int GetSentenceStart(int position) const; - //TODO(pauldb): Add unit tests. virtual int GetSentenceLength(int sentence_id) const; virtual int GetSentenceId(int position) const; @@ -67,8 +69,6 @@ class DataArray { unordered_map word2id; vector id2word; vector data; - // TODO(pauldb): We only need sentence_id for the source language. Maybe we - // can save some memory here. vector sentence_id; vector sentence_start; }; -- cgit v1.2.3